First I'm sorry for any English errors. Second I didn't find any specific bur report place.

I'm not sure of this but in AddAtribute.cs of Dicom Editor, in line 205 we have:

if((!attributeTag.StartsWith("(")) && (!attributeTag.StartsWith("(")))
{
attributeTag = "(" + attributeTag + ")";
}


Shouldn't we have:


if((!attributeTag.StartsWith("(")) && (!attributeTag.EndsWith(")")))
{
attributeTag = "(" + attributeTag + ")";
}


If I'm wrong i apologize, but i thought that it is wrong and i prefer reporting it to be sure.

Thank you

Cheers

We have the Ticket System on the website which you can use to report PRs and CRs. From a first look you are right that this is indeed a bug. Can you please submit a ticket for this, then the developers will pick this up.
Did you notice this bug when using the application?

Floris.

ticket submitted.

And it's better this way, i think:

if(!attributeTag.StartsWith("("))
{
attributeTag = "(" + attributeTag;
}
if (!attributeTag.EndsWith(")"))
{
attributeTag = attributeTag + ")";
}

I separate in two conditions because the user can introduce only one of the parenthesis. You can add another automatic corrections: remove duplicated parenthesis or introduce the '.' in case of fault for example.


that's what I submitted.


No. I'm using the source code. I'm playing with it and find this little bug. Nothing serious.